Re: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler

Gary Benson
2014-07-14T12:03:13Z

Corinna Vinschen wrote:
> On Jul 13 18:11, Pierre Muller wrote:
> > A simple patch would probably be to add a separate check
> > #ifdef SA_ONSTACK
> > sa.sa_flags = SA_O?STACK;
> > #endif
>
> Right, Cygwin doesn't support SA_ONSTACK yet. It should be
> possible to add, but there are no immediate plans to do so.
>
> As for the above, wouldn't it be better to add something like
>
> #ifndef SA_ONSTACK
> #define SA_ONSTACK 0
> #endif
>
> to some header?

I'd prefer not to. Having the conditional where the handler
is installed makes it obvious that the alternate stack is not
available on all systems.

Thanks,
Gary

--