From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5995 invoked by alias); 11 Jul 2014 21:25:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5941 invoked by uid 89); 11 Jul 2014 21:25:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 11 Jul 2014 21:25:45 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6BLPfOP004972 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 Jul 2014 17:25:41 -0400 Received: from host2.jankratochvil.net (ovpn-116-54.ams2.redhat.com [10.36.116.54]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6BLPbHc020019 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 11 Jul 2014 17:25:39 -0400 Date: Fri, 11 Jul 2014 21:33:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: eliz@gnu.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Re: Regression for GDB global --statistics Message-ID: <20140711212537.GA19551@host2.jankratochvil.net> References: <20140630171333.GA2225@host2.jankratochvil.net> <21437.45024.997531.453750@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21437.45024.997531.453750@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00296.txt.bz2 On Wed, 09 Jul 2014 23:10:56 +0200, Doug Evans wrote: > --- a/gdb/testsuite/gdb.base/maint.exp > +++ b/gdb/testsuite/gdb.base/maint.exp > @@ -130,10 +130,11 @@ gdb_expect { > # tests here!! > gdb_test_no_output "maint check-symtabs" > > +# Test per-command stats. > gdb_test_no_output "maint set per-command on" > - > -gdb_test "maint set per-command off" \ > +gdb_test "pwd" \ > "Command execution time: \[0-9.\]+ \\(cpu\\), \[0-9.\]+ \\(wall\\)\[\r\n\]+Space used: $decimal \\(\\+$decimal for this command\\)\[\r\n\]+#symtabs: $decimal \\(\\+$decimal\\), #primary symtabs: $decimal \\(\\+$decimal\\), #blocks: $decimal \\(\\+$decimal\\)" > +gdb_test_no_output "maint set per-command off" Is it needed to change this behavior? It may break some user scripts working fine with previous GDB stable releases. Besides that the startup statistics regression is not tested here but I can post then a testcase for it. Thanks, Jan