From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7650 invoked by alias); 11 Jul 2014 12:53:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7596 invoked by uid 89); 11 Jul 2014 12:53:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 11 Jul 2014 12:53:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6BCr80l005395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 11 Jul 2014 08:53:08 -0400 Received: from blade.nx (ovpn-116-128.ams2.redhat.com [10.36.116.128]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6BCr7OH016219; Fri, 11 Jul 2014 08:53:08 -0400 Received: by blade.nx (Postfix, from userid 1000) id A0CBB2640C5; Fri, 11 Jul 2014 13:53:06 +0100 (BST) Date: Fri, 11 Jul 2014 12:57:00 -0000 From: Gary Benson To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 07/15] Remove GDBSERVER use from nat/i386-dregs.c Message-ID: <20140711125306.GC2695@blade.nx> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-8-git-send-email-gbenson@redhat.com> <87k37ldrz4.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k37ldrz4.fsf@fleche.redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00263.txt.bz2 Tom Tromey wrote: > >>>>> "Gary" == Gary Benson writes: > > Gary> This removes the use of GDBSERVER from nat/i386-dregs.c. > Gary> Neither defs.h or server.h are included: the specific files > Gary> required are listed instead. Also, a declaration previously > Gary> made only outside of gdbserver is made unconditional. > > Gary> -#ifdef GDBSERVER > Gary> -#include "server.h" > Gary> -#else > Gary> -#include "defs.h" > Gary> -#include "inferior.h" > Gary> -#endif > Gary> +#include "common-utils.h" > > I think this should include config.h first. common-utils.h includes it. Or did you mean the gnulib one? Thanks, Gary -- http://gbenson.net/