From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18674 invoked by alias); 9 Jul 2014 18:20:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18651 invoked by uid 89); 9 Jul 2014 18:20:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Jul 2014 18:20:22 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s69IKIPF011710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jul 2014 14:20:19 -0400 Received: from blade.nx (ovpn-116-101.ams2.redhat.com [10.36.116.101]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s69IKHOj027599; Wed, 9 Jul 2014 14:20:18 -0400 Received: by blade.nx (Postfix, from userid 1000) id C8FE02640BF; Wed, 9 Jul 2014 19:20:16 +0100 (BST) Date: Wed, 09 Jul 2014 18:20:00 -0000 From: Gary Benson To: "Breazeal, Don" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 02/15] Remove some GDBSERVER checks from linux-ptrace Message-ID: <20140709182016.GA17984@blade.nx> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-3-git-send-email-gbenson@redhat.com> <53BD7B6C.8030205@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53BD7B6C.8030205@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00195.txt.bz2 Breazeal, Don wrote: > On 7/9/2014 3:37 AM, Gary Benson wrote: > > This patch removes some GDBSERVER checks from nat/linux-ptrace.c. > > Currently the code uses a compile-time check to decide whether > > some flags should be used. This changes the code to instead let > > users of the module specify an additional set of flags; and then > > changes gdb's linux-nat.c to call this function. At some later > > date, when the back ends are fully merged, we will be able to > > remove this function again. > > I just want to point out that I'm doing something similar as part > of my work on follow-fork for extended remote, based on Tom's > suggestion here: > > https://sourceware.org/ml/gdb-patches/2014-05/msg00486.html > > In my case it adds "base" options and the capability to set the > ptrace options to the "additional" options at the caller's > discretion, such as when gdbserver receives the enable-extended-mode > packet. So, no objection, just wanted to let you know that I hope > to submit somewhat different changes to the same code soon. The patch I posted is basically an updated version of the patch Tom posted there--the only change IIRC is that linux-ptrace.c is now in "nat" rather than "common". Do you need me to change anything about this parch, or is it ok for you to work with? Thanks, Gary -- http://gbenson.net/