From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9568 invoked by alias); 7 Jul 2014 20:30:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9551 invoked by uid 89); 7 Jul 2014 20:30:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 07 Jul 2014 20:30:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9A802116300; Mon, 7 Jul 2014 16:30:03 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iobPWYo1uJwx; Mon, 7 Jul 2014 16:30:03 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7316F11629D; Mon, 7 Jul 2014 16:30:03 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4B8FD40F62; Mon, 7 Jul 2014 13:30:02 -0700 (PDT) Date: Mon, 07 Jul 2014 20:30:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PUSHED] PR gdb/17096: async support breaks remote debugging on Windows Message-ID: <20140707203002.GM6038@adacore.com> References: <1404756790-6767-1-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404756790-6767-1-git-send-email-palves@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-07/txt/msg00135.txt.bz2 > gdb/ > 2014-07-07 Pedro Alves > > gdb/17096 > * remote.c (async_handle_remote_sigint) > (async_handle_remote_sigint_twice): Call > gdb_call_async_signal_handler instead of > mark_async_signal_handler. It looks like the remote.c patch was missing, and since I looked it up to take a look, I thought I might as well provide it here as well! Thanks for working on this one, Pedro. -- Joel diff --git a/gdb/remote.c b/gdb/remote.c index b6f3ddb..3aa030c 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -4818,7 +4818,9 @@ static void async_handle_remote_sigint (int sig) { signal (sig, async_handle_remote_sigint_twice); - mark_async_signal_handler (async_sigint_remote_token); + /* Note we need to go through gdb_call_async_signal_handler in order + to wake up the event loop on Windows. */ + gdb_call_async_signal_handler (async_sigint_remote_token, 0); } /* Signal handler for SIGINT, installed after SIGINT has already been @@ -4828,7 +4830,8 @@ static void async_handle_remote_sigint_twice (int sig) { signal (sig, async_handle_remote_sigint); - mark_async_signal_handler (async_sigint_remote_twice_token); + /* See note in async_handle_remote_sigint. */ + gdb_call_async_signal_handler (async_sigint_remote_twice_token, 0); } /* Perform the real interruption of the target execution, in response