From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14574 invoked by alias); 27 Jun 2014 09:28:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14564 invoked by uid 89); 27 Jun 2014 09:28:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Jun 2014 09:28:42 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s5R9SZEo029928; Fri, 27 Jun 2014 11:28:35 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s5R9SZPG020219; Fri, 27 Jun 2014 11:28:35 +0200 (CEST) Date: Fri, 27 Jun 2014 09:28:00 -0000 Message-Id: <201406270928.s5R9SZPG020219@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: gbenson@redhat.com CC: gdb-patches@sourceware.org In-reply-to: <1403860209-475-1-git-send-email-gbenson@redhat.com> (message from Gary Benson on Fri, 27 Jun 2014 10:10:02 +0100) Subject: Re: [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c References: <1403860209-475-1-git-send-email-gbenson@redhat.com> X-SW-Source: 2014-06/txt/msg00924.txt.bz2 > From: Gary Benson > Date: Fri, 27 Jun 2014 10:10:02 +0100 > > Hi all, > > This series refactors the shared code in {i386,amd64}-linux-nat.c into > the new files x86-linux-nat.[ch] and i386-linux-nat.h. The first five > patches remove spurious changes between the files so that the code to > be shared is identical: > > 1/7 - Rename identical functions > 2/7 - Merge {i386,amd64}_linux_read_description > 3/7 - Merge ps_get_thread_area > 4/7 - Pull out common parts of _initialize_{i386,amd64}_linux_nat > 5/7 - Comment and whitespace changes > > The sixth patch moves the shared code into the new files and does all > the makefile and build system updates: > > 6/7 - Move duplicated code into new files > > The seventh patch tidies the blocks of #include directives at the > tops of {i386,amd64}-linux-nat.c: > > 7/7 - Tidy #include lists > > This final patch is not strictly necessary for the series, but it > makes things tidier. > > Is this ok to commit? Sorry, no. Perhaps more code can be shared between i386-linux-nat.c and amd64-linux-nat.c, but this goes too far and turns things into #ifdef spagetthi. It also breaks established naming conventions.