From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9364 invoked by alias); 23 Jun 2014 08:18:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9349 invoked by uid 89); 23 Jun 2014 08:18:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Jun 2014 08:18:19 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5N8IGdm010793 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Jun 2014 04:18:16 -0400 Received: from blade.nx (ovpn-116-92.ams2.redhat.com [10.36.116.92]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5N8IGnN021372; Mon, 23 Jun 2014 04:18:16 -0400 Received: by blade.nx (Postfix, from userid 1000) id 5BEE82623F0; Mon, 23 Jun 2014 09:18:15 +0100 (BST) Date: Mon, 23 Jun 2014 08:18:00 -0000 From: Gary Benson To: Doug Evans Cc: Tom Tromey , gdb-patches Subject: Re: [PATCH v2 10/14] make dwarf_expr_frame_base_1 public Message-ID: <20140623081815.GA16611@blade.nx> References: <1403279874-23781-1-git-send-email-tromey@redhat.com> <1403279874-23781-11-git-send-email-tromey@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00802.txt.bz2 Doug Evans wrote: > On Jun 20, 2014 6:33 PM, "Tom Tromey" wrote: > > > > This exports dwarf_expr_frame_base_1 so that other code can use it. > > > > 2014-06-20 Tom Tromey > > > > * dwarf2loc.h (dwarf_expr_frame_base_1): Declare. > > * dwarf2loc.c (dwarf_expr_frame_base_1): Now public. > > [apologies for the repeat ... curse you gmail ...] > > Can you remove the _1? > (renaming it as needed) > I see the non _1 version is also static, so some reasonable renaming > (perhaps of both) should be simple enough. Is there some convention about what "_1" means in a function name? Cheers, Gary -- http://gbenson.net/