From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-113611-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23662 invoked by alias); 18 Jun 2014 17:48:31 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23651 invoked by uid 89); 18 Jun 2014 17:48:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: glazunov.sibelius.xs4all.nl
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Jun 2014 17:48:30 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s5IHmMev025744;	Wed, 18 Jun 2014 19:48:23 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s5IHmM3H005254;	Wed, 18 Jun 2014 19:48:22 +0200 (CEST)
Date: Wed, 18 Jun 2014 17:48:00 -0000
Message-Id: <201406181748.s5IHmM3H005254@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: palves@redhat.com
CC: gbenson@redhat.com, gdb-patches@sourceware.org
In-reply-to: <53A1B9E8.5010504@redhat.com> (message from Pedro Alves on Wed,	18 Jun 2014 17:10:16 +0100)
Subject: Re: [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch]
References: <1403104976-2492-1-git-send-email-gbenson@redhat.com> <201406181606.s5IG6Mud000672@glazunov.sibelius.xs4all.nl> <53A1B9E8.5010504@redhat.com>
X-SW-Source: 2014-06/txt/msg00683.txt.bz2

> Date: Wed, 18 Jun 2014 17:10:16 +0100
> From: Pedro Alves <palves@redhat.com>
> 
> On 06/18/2014 05:06 PM, Mark Kettenis wrote:
> 
> > What is the whole point about this excercise?
> 
> Reduce duplication and thus reduce maintenance burden.  The same code is
> implemented twice, both in GDB and in GDBserver.
> We've had to patch both sides of the fence several times in the
> past years.  If we had already had this, it would have saved effort.
> Can't rewrite history now, but we can avoid similar duplicate effort
> in the future.  This specific bit is mentioned explicitly in:
> 
>   https://sourceware.org/gdb/wiki/Common#Arch-specific_bits_of_the_target_backends

But common code lives in common/, and this diff moves things into
nat/.  How does that unduplicate things?