From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11926 invoked by alias); 18 Jun 2014 13:30:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11909 invoked by uid 89); 18 Jun 2014 13:30:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Jun 2014 13:30:39 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5IDSYUL012749 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Jun 2014 09:28:34 -0400 Received: from blade.nx (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5IDSX6h016536; Wed, 18 Jun 2014 09:28:34 -0400 Received: by blade.nx (Postfix, from userid 1000) id 07C652623F0; Wed, 18 Jun 2014 14:28:32 +0100 (BST) Date: Wed, 18 Jun 2014 13:30:00 -0000 From: Gary Benson To: Siva Chandra , Pedro Alves Cc: gdb-patches Subject: Re: [PATCH 11/15] Rename functions and make nonstatic as necessary Message-ID: <20140618132832.GA6225@blade.nx> References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> <1403014378-4349-12-git-send-email-gbenson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00654.txt.bz2 Siva Chandra wrote: > On Tue, Jun 17, 2014 at 7:12 AM, Gary Benson wrote: > > This commit renames the functions that are to be shared. > > Functions to be shared that were static are made nonstatic. > > I thinking making the functions nonstatic in this part was not > correct. The build currently fails when built with > "-Werror=missing-prototypes" as 14/15 has not yet been committed. My apologies Siva. Pedro, should I commit the remaining piece now, and work on the i386_insert_hw_breakpoint as a separate patch? Thanks, Gary -- http://gbenson.net/