Re: [PATCH 01/23] dwarf: add dwarf3 DW_OP_push_object_address opcode

Tom Tromey
2014-06-05T20:47:40Z

>>>>> "Keven" == Keven Boell <keven.boell@intel.com> writes:

Keven> The opcode pushes the address of the object being evaluated. The
Keven> semantic is equivalent to the implicit push of the base address
Keven> of a data member location.

This looks good.

However, normally if one updates the DWARF expression evaluator, one
should either try to update the DWARF->AX translator in dwarf2loc.c, or
provide some rationale explaining why it either can't be done or is
otherwise undesirable. In this case I think the translation seems
doable. See dwarf2_compile_expr_to_ax. There's also
dwarf2read.c:decode_locdesc, but it is hackier and more likely to be
ignorable.

Tom