From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29209 invoked by alias); 17 Jun 2014 16:10:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29199 invoked by uid 89); 17 Jun 2014 16:10:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 16:10:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HGA0qd026454 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 17 Jun 2014 12:10:00 -0400 Received: from blade.nx (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HG9xot013621; Tue, 17 Jun 2014 12:09:59 -0400 Received: by blade.nx (Postfix, from userid 1000) id B2B6E2623FA; Tue, 17 Jun 2014 17:09:58 +0100 (BST) Date: Tue, 17 Jun 2014 16:10:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 04/15] Comment changes Message-ID: <20140617160958.GA6680@blade.nx> References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> <1403014378-4349-5-git-send-email-gbenson@redhat.com> <53A062B1.5060005@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53A062B1.5060005@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00613.txt.bz2 Pedro Alves wrote: > On 06/17/2014 03:12 PM, Gary Benson wrote: > > This commit fixes various whitespace differences between > > s/whitespace/comment/ Oops :) > > /* In non-stop/async, threads can be running while we change the > > - STATE (and friends). Say, we set a watchpoint, and let threads > > > + global dr_mirror (and friends). Say, we set a watchpoint, and > > + let threads resume. Now, say you delete the watchpoint, or > > Wrong direction, here, I'm afraid. There's no _global_ dr_mirror > anymore. There used to be one, before multi-process. Is s/global dr_mirror/dr_mirror/ ok, or something else? Cheers, Gary -- http://gbenson.net/