Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [pushed/obv] DOC: Add space before the opening parenthesis in function descriptions
Date: Mon, 09 Jun 2014 15:15:00 -0000	[thread overview]
Message-ID: <20140609151506.GB5032@adacore.com> (raw)
In-Reply-To: <CAGyQ6gzcNyfSftYdPL6065WChG5V7bFg=znYDH+0F4DhGrj79g@mail.gmail.com>

> 2014-06-09  Siva Chandra Reddy  <sivachandra@google.com>
> 
>         * python.texi (Xmethod API): Add space before the opening
>         parenthesis in function descriptions.

> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index 2f1b71f..4688783 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -2270,7 +2270,7 @@ disabled.
>  The class @code{XMethod} is a convenience class with same
>  attributes as above along with the following constructor:
>  
> -@defun XMethod.__init__(self, name)
> +@defun XMethod.__init__ (self, name)

Should we NOT put a space there? The recommendation for Python
code is to not have spaces before parens (see PEP8).

-- 
Joel


  parent reply	other threads:[~2014-06-09 15:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09 14:23 Siva Chandra
2014-06-09 14:48 ` Eli Zaretskii
2014-06-09 15:15 ` Joel Brobecker [this message]
2014-06-09 16:16   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140609151506.GB5032@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox