Re: [PATCH 3/3 v4] Demangler crash handler

Gary Benson
2014-06-06T19:27:56Z

Florian Weimer wrote:
> * Gary Benson:
> > + sigaction (SIGSEGV, &sa, &old_sa);
> > + crash_signal = SIGSETJMP (gdb_demangle_jmp_buf);
> > + sigaction (SIGSEGV, &old_sa, NULL);
>
> That's quite a bit of additional work for each demangler invocation.
> Is this visible with things like tab completion?

I tested this a while back: it's not noticable.

FWIW I did time gdb -nx -batch \
/usr/lib64/libreoffice/program/soffice.bin \
-ex "start" -ex "complete b" > /dev/null

That invokes the demangler some 3,100,000 times. I don't remember
the exact times but they were of the order of 50s in both cases.

Thanks,
Gary

--