From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6547 invoked by alias); 9 Jun 2014 10:32:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6535 invoked by uid 89); 9 Jun 2014 10:32:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jun 2014 10:32:50 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s59AWn6q011422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 9 Jun 2014 06:32:49 -0400 Received: from host2.jankratochvil.net (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s59AWkJF028030 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 9 Jun 2014 06:32:48 -0400 Date: Mon, 09 Jun 2014 10:32:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [patch] linux_nat_kill() compat. with linux-2.4.x Message-ID: <20140609103245.GA29982@host2.jankratochvil.net> References: <20140316135916.GA31463@host2.jankratochvil.net> <537CA0E7.6010505@redhat.com> <20140606201514.GA23334@host2.jankratochvil.net> <53958C88.4070209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53958C88.4070209@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00367.txt.bz2 On Mon, 09 Jun 2014 12:29:28 +0200, Pedro Alves wrote: > On 06/06/2014 09:15 PM, Jan Kratochvil wrote: > > It also may hang somewhere else and not in linux_nat_kill(). > > Right. I'd say it's much more likely (even though not very likely, tbc) > that we see hangs elsewhere than in linux_nat_kill now. E.g., GDB core's > is_executing state getting out of sync with lwp->stopped. > > > This patch made GDB foolproof against any state of inferior when killing the > > inferior so that GDB could no longer hang. But it would hide some possible > > remaining bugs in the code (which may be causing the GDB hangs). > > Right, I'd rather just fix the GDB bugs, and only consider such a patch > if we need to work around a kernel bug (though I'd rather just > ignore very old kernels like 2.4 by now). OK, so according to the approach chosen above considering this patch dropped. Jan