Re: [PATCH 0/3 v4] Demangler crash handler

Doug Evans
2014-06-05T16:19:25Z

On Thu, Jun 5, 2014 at 6:01 AM, Gary Benson <gbenson@redhat.com> wrote:
> Hi all,
>
> This patch is an updated version of the demangler crash handler I
> posted yesterday. The main changes from the previous version are:
>
> 1) All #ifdef SIGSEGV conditionals have been removed.
>
> 2) If the user set "ulimit -c 0" then no core file will be
> created and a warning will be printed. This mirrors what
> internal_error and internal_warning currently do.
>
> 3) A separate signal stack is created for the SIGSEGV handler
> to allow it to function correctly if the normal process
> stack overflows. This signal stack is currently only used
> by the SIGSEGV handler--all other signal handlers use the
> normal process stack as before.
>
> Doug requested that I change the patch to emit warnings for every
> demangler crash, not just the first.

Umm, that's not what I said, to be precise, and it was more of a
suggestion for discussion than a request.

> I've not done this, my reason
> being that subsequent failures could have been caused by the first,
> by memory corruption or some leftover state: they could be bogus,
> and could lead to us chasing bugs that don't exist. I prefer this
> way, but I'm not hung up on it and if it's a blocker for Doug or
> anyone else I will add the extra warnings.

It's not a blocker to me.