Re: [PATCH 0/3 v4] Demangler crash handler

Gary Benson
2014-06-06T09:19:07Z

Doug Evans wrote:
> On Thu, Jun 5, 2014 at 6:01 AM, Gary Benson <gbenson@redhat.com> wrote:
> > Doug requested that I change the patch to emit warnings for every
> > demangler crash, not just the first.
>
> Umm, that's not what I said, to be precise, and it was more of a
> suggestion for discussion than a request.

Ah, I misunderstood.

>
> > I've not done this, my reason
> > being that subsequent failures could have been caused by the first,
> > by memory corruption or some leftover state: they could be bogus,
> > and could lead to us chasing bugs that don't exist. I prefer this
> > way, but I'm not hung up on it and if it's a blocker for Doug or
> > anyone else I will add the extra warnings.
>
> It's not a blocker to me.

Great :)

Thanks,
Gary

--