From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10082 invoked by alias); 6 Jun 2014 09:09:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10060 invoked by uid 89); 6 Jun 2014 09:09:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Jun 2014 09:09:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5698vWt004575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 6 Jun 2014 05:08:58 -0400 Received: from blade.nx (ovpn-116-93.ams2.redhat.com [10.36.116.93]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5698tLt003816; Fri, 6 Jun 2014 05:08:56 -0400 Received: by blade.nx (Postfix, from userid 1000) id 160C02622D4; Fri, 6 Jun 2014 10:08:55 +0100 (BST) Date: Fri, 06 Jun 2014 09:09:00 -0000 From: Gary Benson To: Doug Evans Cc: "gdb-patches@sourceware.org" , Andrew Burgess , Eli Zaretskii , Florian Weimer , Mark Kettenis , Pedro Alves , Tom Tromey Subject: Re: [PATCH 2/3 v4] Refactor and expose core-dumping functionality Message-ID: <20140606090854.GB28998@blade.nx> References: <20140605130140.GA20572@blade.nx> <20140605130322.GC20572@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00307.txt.bz2 Doug Evans wrote: > On Thu, Jun 5, 2014 at 6:03 AM, Gary Benson wrote: > > This patch exposes the functions that dump core outside utils.c. > > The function can_dump_core has been split into two new functions, > > check_can_dump_core and warn_cant_dump_core so that the check and > > the printed warning can be separated. A new function > > check_can_dump_core_warn replaces the original can_dump_core. > > check_can_dump_core feels a bit clumsy over the original > can_dump_core. can_dump_core (or can_dump_core_p) reads better to > me. [And now it does what it says it does, without the side-effect > of the printf.] > > Not sure if I'd rename check_can_dump_core_warn (or delete it). Ok, I renamed check_can_dump_core back to the original can_dump_core, and I renamed check_can_dump_core_warn as can_dump_core_warn (it's called twice, so there would be duplication if I removed it). I won't post another patch series for such a small change but the updated patches are in my github (http://tinyurl.com/dmcc-v4-2 and http://tinyurl.com/dmcc-v4-3) if you would like to take a look. Patch 2 is the important one, patch 3 only has a couple of lines changed. Thanks, Gary -- http://gbenson.net/