From: Kyle McMartin <kmcmarti@redhat.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] aarch64: implement walking over the stack protector
Date: Thu, 05 Jun 2014 20:06:00 -0000 [thread overview]
Message-ID: <20140605200621.GN15355@redacted.bos.redhat.com> (raw)
In-Reply-To: <20140603145108.GF15355@redacted.bos.redhat.com>
On Tue, Jun 03, 2014 at 10:51:08AM -0400, Kyle McMartin wrote:
> On Mon, Jun 02, 2014 at 10:42:32PM -0700, Andrew Pinski wrote:
> > > + adrp x0, __stack_chk_guard
> > > + add x0, x0, #:lo12:__stack_chk_guard
> > > + ldr x0, [x0]
> > > + str x0, [x29, #end-of-stack]
> >
> > Can you expand this for ILP32? The sequence is the same except to use
> > w0 instead of x0. Otherwise I can put it on my todo list to after I
> > submit the gdb support for ILP32.
> >
>
> I'll look into it. Thanks Andrew.
>
Finally got a toolchain built that supports ilp32... looks like the
existing code should work for it. The only difference (not sure if it's
because of gcc HEAD or what) is using w1 instead of x0 repeated for the
ldr/str, which looks to be satisfied by the rt/rt2 tests and size=10
included in the decode_masked_match. I'll try to build a static ilp32
binary to test it meanwhile, but I've had some other issues with gcc
HEAD.
regards, Kyle
next prev parent reply other threads:[~2014-06-05 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 5:00 [PATCH 0/2] aarch64: skip over stack protector setup in function prologues Kyle McMartin
2014-06-03 5:02 ` [PATCH 1/2] aarch64: extend decode_adrp to decode immediate offset Kyle McMartin
2014-06-03 8:22 ` Marcus Shawcroft
2014-06-03 14:50 ` Kyle McMartin
2014-06-03 5:03 ` [PATCH 2/2] aarch64: implement walking over the stack protector Kyle McMartin
2014-06-03 5:42 ` Andrew Pinski
2014-06-03 14:51 ` Kyle McMartin
2014-06-05 20:06 ` Kyle McMartin [this message]
2014-06-05 20:36 ` Andrew Pinski
2014-06-05 20:53 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605200621.GN15355@redacted.bos.redhat.com \
--to=kmcmarti@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox