From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1553 invoked by alias); 4 Jun 2014 18:25:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1539 invoked by uid 89); 4 Jun 2014 18:25:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 18:25:42 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s54IPWHO019736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Jun 2014 14:25:33 -0400 Received: from blade.nx (ovpn-116-110.ams2.redhat.com [10.36.116.110]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s54IPUfj013522; Wed, 4 Jun 2014 14:25:31 -0400 Received: by blade.nx (Postfix, from userid 1000) id B75EE26243C; Wed, 4 Jun 2014 19:25:29 +0100 (BST) Date: Wed, 04 Jun 2014 18:25:00 -0000 From: Gary Benson To: Doug Evans Cc: Eli Zaretskii , "gdb-patches@sourceware.org" , Andrew Burgess , Florian Weimer , Mark Kettenis , Pedro Alves , Tom Tromey Subject: Re: [PATCH 2/2 v3] Demangler crash handler Message-ID: <20140604182529.GA14897@blade.nx> References: <20140604100755.GA7570@blade.nx> <20140604100957.GC7570@blade.nx> <834n017z8w.fsf@gnu.org> <20140604133603.GC10121@blade.nx> <83sink7pww.fsf@gnu.org> <20140604142844.GB11730@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00204.txt.bz2 Doug Evans wrote: > On Wed, Jun 4, 2014 at 7:28 AM, Gary Benson wrote: > > Eli Zaretskii wrote: > > > > From: Gary Benson > > > > > > > > Eli Zaretskii wrote: > > > > > > From: Gary Benson > > > > > > > > > > > > Eli pointed out that SIGSEGV is an ANSI-standard signal > > > > > > but I found various other SIGSEGV checks in GDB > > > > > > > > > > They should all be removed. > > > > > > > > Ok, I'll do this. Should I commit the change as obvious? > > > > > > I think so, yes. > > > > Ok, I'll do that. > > Are we talking about #ifdef SIGSEGV in, e.g., common/signals.c? Yes. > If one goes down this path, I think the patch while perhaps > "obvious" would become a bit involved (why just SEGV?) and > thus the obviousness diminishes. > I think it diminishes to a point where the obviousness is gone. > Please submit any such patch for review. Having started looking into this I am inclined to agree. I couldn't find an authoritative list, but the Linux kernel sources indicate that SIGINT, SIGILL, SIGABRT, SIGFPE, SIGSEGV and SIGTERM are ANSI. Eli said that list agreed with his references, so I'll work on unwrapping those. I will post the patch for review. Thanks, Gary -- http://gbenson.net/