From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27570 invoked by alias); 4 Jun 2014 13:41:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27523 invoked by uid 89); 4 Jun 2014 13:41:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 13:41:02 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s54Devhd004673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Jun 2014 09:40:57 -0400 Received: from blade.nx (ovpn-116-110.ams2.redhat.com [10.36.116.110]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s54Deu9R026656; Wed, 4 Jun 2014 09:40:57 -0400 Received: by blade.nx (Postfix, from userid 1000) id CB64B26243D; Wed, 4 Jun 2014 14:40:55 +0100 (BST) Date: Wed, 04 Jun 2014 13:41:00 -0000 From: Gary Benson To: Eli Zaretskii Cc: gdb-patches@sourceware.org, aburgess@broadcom.com, xdje42@gmail.com, fw@deneb.enyo.de, mark.kettenis@xs4all.nl, palves@redhat.com, tromey@redhat.com Subject: Re: [PATCH 0/2 v3] Demangler crash handler Message-ID: <20140604134055.GD10121@blade.nx> References: <20140604100755.GA7570@blade.nx> <8338fl7z67.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8338fl7z67.fsf@gnu.org> X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00162.txt.bz2 Eli Zaretskii wrote: > > From: Gary Benson > > > > The news file entries for the commit would be: > > > > * New options > > > > maint set catch-demangler-crashes (on|off) > > maint show catch-demangler-crashes > > Control whether GDB should attempt to catch crashes in the symbol > > name demangler. The default is to attempt to catch crashes. If > > enabled, the first time a crash is caught, a core file is created, > > the offending symbol is displayed and the user is presented with > > the option to terminate the current session. > > > > maint set demangler-warning quit (yes|no|ask) > > When GDB catches a crash in the symbol name demangler it can offer > > the user the opportunity to both quit GDB and create a core file of > > the current GDB session. These options control whether or not to > > do either of these. The default is to create a core file and to ask > > the user whether to quit. > > > > * New commands > > > > maint demangler-warning > > Cause GDB to call the internal function demangler_warning and > > hence behave as though an internal error in the demangler has > > been detected. > > > > Is this ok to commit? > > The above is too detailed for NEWS. Do not just copy the text > from the manual, but instead provide a very short (preferably a > single-sentence) summary of the new option. How about these? maint set catch-demangler-crashes (on|off) maint show catch-demangler-crashes Control whether GDB should attempt to catch crashes in the symbol name demangler. maint set demangler-warning quit (yes|no|ask) Control whether GDB should exit if it catches a crash in the symbol name demangler. I don't know I could shorten "maint demangler-warning"'s entry any more without it becoming meaningless. Thanks, Gary -- http://gbenson.net/