From: Joel Brobecker <brobecker@adacore.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org,
Alan Modra <amodra@gmail.com>,
Hans-Peter Nilsson <hp@bitrange.com>,
Tom Tromey <tromey@redhat.com>
Subject: Re: [RFA v2] Make it easy to make --disable-werror the default for both binutils and gdb
Date: Wed, 04 Jun 2014 12:55:00 -0000 [thread overview]
Message-ID: <20140604125541.GT4289@adacore.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1406041337580.3047@tp.orcam.me.uk>
> > . Use "-a" instead of "&&" in the test expression; (H-P)
>
> I think Hans-Peter's suggestion was the other way round, its "&&" that is
> portable while "-a" is likely not to work with non-GNU `test' or with
> plain Bourne shells (where it is a builtin). This is what the autoconf
> manual has to say about it in its portability section:
Hmmm, I see. Thanks for theh clarification.
I propose the following: Keep the patch I propose as is for now, as it
does not make things worse, and also keep things consistent. And then
follow that up with a patch which switches the operators, all of them,
to using &&.
--
Joel
next prev parent reply other threads:[~2014-06-04 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 15:57 Joel Brobecker
2014-06-04 0:43 ` Alan Modra
2014-06-04 12:44 ` Maciej W. Rozycki
2014-06-04 12:55 ` Joel Brobecker [this message]
2014-06-04 17:43 ` Maciej W. Rozycki
2014-06-04 21:00 ` Tom Tromey
2014-06-05 12:55 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604125541.GT4289@adacore.com \
--to=brobecker@adacore.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hp@bitrange.com \
--cc=macro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox