From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8347 invoked by alias); 4 Jun 2014 12:47:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8289 invoked by uid 89); 4 Jun 2014 12:47:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 04 Jun 2014 12:47:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C246E1161B1; Wed, 4 Jun 2014 08:47:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CtMz-zbVL0+O; Wed, 4 Jun 2014 08:47:06 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 935951161B0; Wed, 4 Jun 2014 08:47:06 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 87AA540EB3; Wed, 4 Jun 2014 05:47:08 -0700 (PDT) Date: Wed, 04 Jun 2014 12:47:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [ping] [PATCH] Different outputs affected by locale Message-ID: <20140604124708.GR4289@adacore.com> References: <1401192650-29688-1-git-send-email-yao@codesourcery.com> <538EAEE5.2080708@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <538EAEE5.2080708@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-06/txt/msg00152.txt.bz2 > > 2014-05-27 Yao Qi > > > > * gdb.base/wchar.exp: Execute command 'p repeat[1]' and extract > > cent from the output. This is a patch that I felt would be better reviewed by Tom, but we'd have to wait for him to be back. When I read your patch, I thought that the approach you took was weakening the test a little, because if GDB started printing the character incorrectly, you would not notice it anymore. -- Joel