From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19644 invoked by alias); 27 May 2014 18:10:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19632 invoked by uid 89); 27 May 2014 18:10:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 27 May 2014 18:10:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A403411619A; Tue, 27 May 2014 14:10:35 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1bPpP7Ba4820; Tue, 27 May 2014 14:10:35 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 70265116181; Tue, 27 May 2014 14:10:35 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C124C40E1F; Tue, 27 May 2014 11:10:33 -0700 (PDT) Date: Tue, 27 May 2014 18:10:00 -0000 From: Joel Brobecker To: Brad Mouring Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/source.c: Fix source path substitution Message-ID: <20140527181033.GA3357@adacore.com> References: <1400878971-6311-1-git-send-email-brad.mouring@ni.com> <20140523234959.GX22822@adacore.com> <20140524000034.GY22822@adacore.com> <20140527131716.GA8300@linuxgetsreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140527131716.GA8300@linuxgetsreal> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00675.txt.bz2 > > > First of all, the administrative stuff. There are a few important pieces > > > missing from your subscription. I invite you read the file gdb/CONTRIBUTE > > > which should explain it all. Do not hesitate to ask questions if needed. > > Will do. I take it this info belongs in the commit message, or would > you rather it be a cover letter-type email? Can you explain which info you are referring to? About cover letters, they typically seem to be used when submitting a series of patch, rather than a patch alone, to introduce the series, or to provide info that really does not belong in the revision log, Other than that, having the details in the revision log is usually mostly positive, but we can help you with our review if we think we can help improving it. -- Joel