From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 726 invoked by alias); 22 May 2014 16:02:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 667 invoked by uid 89); 22 May 2014 16:02:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=unavailable version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 May 2014 16:02:23 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4MG2ARu021184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 May 2014 12:02:11 -0400 Received: from blade.nx (ovpn-116-100.ams2.redhat.com [10.36.116.100]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4MG29M3029486; Thu, 22 May 2014 12:02:10 -0400 Received: by blade.nx (Postfix, from userid 1000) id 01710262414; Thu, 22 May 2014 17:02:08 +0100 (BST) Date: Thu, 22 May 2014 16:02:00 -0000 From: Gary Benson To: Thomas Schwinge Cc: Andrew Burgess , Ian Lance Taylor , gcc-patches , Jason Merrill , gdb-patches@sourceware.org Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special. Message-ID: <20140522160208.GC25201@blade.nx> References: <1399646123-9960-1-git-send-email-aburgess@broadcom.com> <536E7A72.1040203@broadcom.com> <20140514090125.GA4974@blade.nx> <537337AF.3020806@broadcom.com> <20140514142016.GA32660@blade.nx> <87a9aavxdr.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a9aavxdr.fsf@kepler.schwinge.homeip.net> X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00557.txt.bz2 Hi Thomas, Thomas Schwinge wrote: > In GCC, I'm consistenly seeing the following new failure: > > ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected > FAIL at line 4350, options --format=auto --no-params: > in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > out: (null) > exp: > ./test-demangle: 895 tests, 1 failures > make[2]: *** [check-cplus-dem] Error 1 > > The patch was committed incompletely; I added the missing last line in > r210803: [snip] > @@ -4347,3 +4347,4 @@ void post >(std::function&&)::{lambda()#1}*& std > --format=auto --no-params > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z I thought that extra line was a mistake; I thought each test was precisely three lines: # options # input to be demangled # expected output What is the extra line here? Thanks, Gary -- http://gbenson.net/