From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4733 invoked by alias); 21 May 2014 13:45:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4675 invoked by uid 89); 21 May 2014 13:45:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 21 May 2014 13:45:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2FF631160D3; Wed, 21 May 2014 09:45:45 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id H5UflCnHdIlj; Wed, 21 May 2014 09:45:45 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E42451160AF; Wed, 21 May 2014 09:45:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 712B943848; Wed, 21 May 2014 06:45:44 -0700 (PDT) Date: Wed, 21 May 2014 13:45:00 -0000 From: Joel Brobecker To: Ajit Kumar Agarwal Cc: Michael Eager , Michael Eager , "gdb-patches@sourceware.org" , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Add slr and shr regs and little-endian breakpoint Message-ID: <20140521134544.GL22822@adacore.com> References: <537BC5B9.10601@eagercon.com> <537C5A25.9000003@eagerm.com> <5821f144-e431-4bee-9cd7-33971b5512a3@BN1AFFO11FD019.protection.gbl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5821f144-e431-4bee-9cd7-33971b5512a3@BN1AFFO11FD019.protection.gbl> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00479.txt.bz2 > Here is the problem description. The problem is related to > process_g_packet where the buf_len > 2 * rsa->sizeof_g_packet and > throwing the Error that 'g' packet message reply is too long. This is > because the buf_len calculated in the init_remote_state function for > microblaze target is based On the sizeof_g_packet and > remote_packet_size and the memory_packet_config->size. The > sizeof_g_packet is 236 because the number of reg num is 59 and 2* > sizeof_g_packet comes to 472 .With shr and shl entry and the buf_len > is 472. This does not match the greater than conditional statement and > works fine. Without shr and shl entry,the sizeof_g_packets comes to > 57*4 *2 = 456. This doesn't match the criteria in the > process_g_packet function leading to throwing of error message as " > 'g' packet message reply is too long". > > This is happening when tar remote machine:1234 command is run in gdb. > > >>>These changes don't appear related. Split independent changes in > >>>to separate patches. > > I will split the changes and send the separate patch with shr and shl > reg changes and the little endian breakpoint support. Thanks, Ajit. FWIW, I agree with Michael. Also, when submitting the new patches, please include the description of the problem you are trying to solve in the revision log of your patch. Something like the description you gave above, for instance. This makes archeology a lot easier for us. The good news when doing that is that submitting the patch could be as simple as "git send-email"-ing the patch; that's what I personally do for my own patches, and it's been a real time saver. -- Joel