From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24147 invoked by alias); 20 May 2014 15:29:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24089 invoked by uid 89); 20 May 2014 15:29:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 May 2014 15:29:45 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4KFTcfB012887 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 May 2014 11:29:38 -0400 Received: from host2.jankratochvil.net (ovpn-116-107.ams2.redhat.com [10.36.116.107]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4KFTYhO016617 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 20 May 2014 11:29:37 -0400 Date: Tue, 20 May 2014 15:29:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v5 8/8] Tests for validate symbol file using build-id Message-ID: <20140520152934.GA27766@host2.jankratochvil.net> References: <20140319223004.14668.20989.stgit@host1.jankratochvil.net> <20140319223131.14668.9029.stgit@host1.jankratochvil.net> <87ha4kts54.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ha4kts54.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00429.txt.bz2 On Tue, 20 May 2014 16:57:11 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> 2014-02-26 Aleksandar Ristovski Jan> Tests for validate symbol file using build-id. > Jan> * gdb.server/solib-mismatch-lib.c: New file. > Jan> * gdb.server/solib-mismatch-libmod.c: New file. > Jan> * gdb.server/solib-mismatch.c: New file. > Jan> * gdb.server/solib-mismatch.exp: New file. > > I thought Pedro had wanted these not in gdb.server. > Or am I confusing that with some other patch? In a local copy they are moved back to gdb.base/ . But I haven't re-post the whole series just because of it. Planning to check it in into gdb.base/ . > Jan> +if ![is_remote target] { > Jan> + untested "only gdbserver supports build-id reporting" > Jan> + return -1 > > I was mildly confused to read this. > Isn't build-id also supported natively? For this case of build-id it is not. It was discussed in: Re: [patchv3 7/8] Validate symbol file using build-id Message-ID: <53108EF7.3000708@redhat.com> https://sourceware.org/ml/gdb-patches/2014-02/msg00862.html https://sourceware.org/ml/gdb-patches/2014-03/msg00011.html > How does the new functionality interact with the existing build-id > functionality? Currently only the separate debug info file is located and validated by build-id. This patch is about validating the primary file (without .debug extension - in fact symbol file as GDB uses that file only for symbols). Besides all of these there are additional patches: http://pkgs.fedoraproject.org/cgit/gdb.git/tree/ gdb-6.6-buildid-locate-* which are also about locating the primary files but those patches are for local (NAT) mode. Also this series does not validate / locate the main executable, the Fedora patches above work also for the main executable. It got all a bit messy so I decided to merge it all and preparing it as an update (technically add-on) on this patch series. So also contrary to my original plans in Re: [patchv3 7/8] Validate symbol file using build-id above I am going to implement the local (NAT) mode for locating the files. As I expect GDB is not going to unify LocalRemoteFeatureParity soon enough. It will be about upstreaming the Fedora patchset which is the last largest Fedora-specific patchsets kept. Jan