Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Michael Eager <eager@eagercon.com>,
	Vinod Kathail <vinodk@xilinx.com>,
	Vidhumouli Hunsigida <vidhum@xilinx.com>,
	Nagaraju Mekala <nmekala@xilinx.com>
Subject: Re: [Patch, Microblaze]:  Added support of shr and slr regs, little endian breakpoints,backtrace support and communicate with larger blocks.
Date: Tue, 20 May 2014 14:35:00 -0000	[thread overview]
Message-ID: <20140520143544.GJ22822@adacore.com> (raw)
In-Reply-To: <fb25f6af-56fb-4d62-b366-322130d557be@BL2FFO11FD027.protection.gbl>

> > ChangeLog:
> >  2014-05-20 Ajit Agarwal <ajitkum@xilinx.com>
> > 
> >  * gdb/gdbserver/Makefile.in (microblaze-linux.c) : New target
> 
> >>Not sure if this intended or not, but the entry should be indented
> >>with a tab. No space before the ':'. And all sentences should end
> >>with a period (as well as starting with a capital letter >>as you
> >>did here).
> 
> The comment here is for the ChangeLog written or the coding comment in
> the file Makefile.in.  Sorry to ask this!!

No problem. All my comments were regarding the ChangeLog entry itself.

-- 
Joel


  reply	other threads:[~2014-05-20 14:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  8:17 Ajit Kumar Agarwal
2014-05-20 13:13 ` Joel Brobecker
2014-05-20 14:15   ` Ajit Kumar Agarwal
2014-05-20 14:35     ` Joel Brobecker [this message]
2014-05-20 21:09 ` Michael Eager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140520143544.GJ22822@adacore.com \
    --to=brobecker@adacore.com \
    --cc=ajit.kumar.agarwal@xilinx.com \
    --cc=eager@eagercon.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nmekala@xilinx.com \
    --cc=vidhum@xilinx.com \
    --cc=vinodk@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox