From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25310 invoked by alias); 19 May 2014 15:11:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25297 invoked by uid 89); 19 May 2014 15:11:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 19 May 2014 15:11:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7F36711617A; Mon, 19 May 2014 11:11:23 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id snW+af+gb0Kl; Mon, 19 May 2014 11:11:23 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 471CC116179; Mon, 19 May 2014 11:11:23 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3BE2F43848; Mon, 19 May 2014 08:11:22 -0700 (PDT) Date: Mon, 19 May 2014 15:11:00 -0000 From: Joel Brobecker To: tmirza Cc: Will Newton , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction Message-ID: <20140519151122.GA24643@adacore.com> References: <1399448485-1740-1-git-send-email-tmirza@codesourcery.com> <20140507132511.GB4063@adacore.com> <536A5254.3030402@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <536A5254.3030402@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00355.txt.bz2 > >>>2014-05-06 Taimoor Mirza > >>> > >>> gdb/ > >>> * arm-tdep.c (thumb_analyze_prologue): Fix offset calculation for > >>> ldr.w and ldrd instructions. > >[...] > >>This looks good to me, assuming the testsuite was run with no regressions. > Thanks for the review Will. Yes I ran testsuites. > >Thanks, Will, for reviewing the patch. I concur on both counts: > >patch is approved, but can you please also confirm how the patch > >was tested? > I ran testsuites before and after applying my patch and did not find > any regression. I noticed that there is a new branch on the binutils-gdb repository called CB-2131, and that branch only contains your patch. Does this ring a bell to you? Perhaps that's the name of the branch you used on your end and you pushed it by accident? Thanks, -- Joel