From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27125 invoked by alias); 15 May 2014 11:39:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27114 invoked by uid 89); 15 May 2014 11:39:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 May 2014 11:39:49 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4FBdk7E012688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 May 2014 07:39:46 -0400 Received: from blade.nx (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4FBdi5C030998; Thu, 15 May 2014 07:39:45 -0400 Received: by blade.nx (Postfix, from userid 1000) id 22C442622C8; Thu, 15 May 2014 12:39:44 +0100 (BST) Date: Thu, 15 May 2014 11:39:00 -0000 From: Gary Benson To: Doug Evans Cc: Paul Koning , gdb-patches , Tom Tromey Subject: Re: [PATCH] Prompt user to report bugs Message-ID: <20140515113943.GB13323@blade.nx> References: <20140514110742.GA25550@blade.nx> <1B70C5D6-D845-4F9A-A874-63DF77FB9030@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00224.txt.bz2 Doug Evans wrote: > On Wed, May 14, 2014 at 2:11 PM, wrote: > > On May 14, 2014, at 5:05 PM, Doug Evans wrote: > > > On Wed, May 14, 2014 at 4:07 AM, Gary Benson wrote: > > > > 2014-05-14 Gary Benson > > > > > > > > * utils.c (internal_vproblem): Prompt the user to file a report. > > > > > > > > diff --git a/gdb/utils.c b/gdb/utils.c > > > > index a8a7cb3..905ce6d 100644 > > > > --- a/gdb/utils.c > > > > +++ b/gdb/utils.c > > > > @@ -746,6 +746,14 @@ internal_vproblem (struct internal_problem *problem, > > > > else > > > > internal_error (__FILE__, __LINE__, _("bad switch")); > > > > > > > > + fputs_unfiltered (_("\nThis is a bug, please report it."), gdb_stderr); > > > > + if (REPORT_BUGS_TO[0]) > > > > + { > > > > + fputs_unfiltered (_(" For instructions, see:\n"), gdb_stderr); > > > > + fprintf_unfiltered (gdb_stderr, _("%s."), REPORT_BUGS_TO); > > > > + } > > > > + fputs_unfiltered ("\n\n", gdb_stderr); > > > > + > > > > if (problem->should_dump_core == internal_problem_ask) > > > > { > > > > if (!can_dump_core (reason)) > > > > > > > > > > top.c doesn't wrap "%s." in _(). > > > I don't know if it matters, it's just odd to see "%s." wrapped. > > > > It also seems odd to see “%s.” inside _( ) since there’s nothing > > to translate there. > > That's why it seemed odd to me too. :-) > [Though what do I know ... maybe someone might want to use something > other than "." at the end.] Japanese has a different sentence terminator: http://en.wikipedia.org/wiki/Japanese_punctuation#Full_stop Possibly other languages do to. I'm easy either way, if people want it wrapped I'll wrap it, if people want it bare I can do that too :) Cheers, Gary -- http://gbenson.net/