From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5532 invoked by alias); 14 May 2014 11:22:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5519 invoked by uid 89); 14 May 2014 11:22:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 14 May 2014 11:22:21 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s4EBMELf007200; Wed, 14 May 2014 13:22:14 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s4EBME4c030348; Wed, 14 May 2014 13:22:14 +0200 (CEST) Date: Wed, 14 May 2014 11:22:00 -0000 Message-Id: <201405141122.s4EBME4c030348@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: gbenson@redhat.com CC: gdb-patches@sourceware.org, tromey@redhat.com In-reply-to: <20140514110742.GA25550@blade.nx> (message from Gary Benson on Wed, 14 May 2014 12:07:42 +0100) Subject: Re: [PATCH] Prompt user to report bugs References: <20140514110742.GA25550@blade.nx> X-SW-Source: 2014-05/txt/msg00199.txt.bz2 > Date: Wed, 14 May 2014 12:07:42 +0100 > From: Gary Benson > > Hi all, > > This patch prints a couple of extra lines in internal_vproblem > to prompt the user to report the bug that's just happened. > > Ok to commit? Can't hurt. > -- > 2014-05-14 Gary Benson > > * utils.c (internal_vproblem): Prompt the user to file a report. > > diff --git a/gdb/utils.c b/gdb/utils.c > index a8a7cb3..905ce6d 100644 > --- a/gdb/utils.c > +++ b/gdb/utils.c > @@ -746,6 +746,14 @@ internal_vproblem (struct internal_problem *problem, > else > internal_error (__FILE__, __LINE__, _("bad switch")); > > + fputs_unfiltered (_("\nThis is a bug, please report it."), gdb_stderr); > + if (REPORT_BUGS_TO[0]) > + { > + fputs_unfiltered (_(" For instructions, see:\n"), gdb_stderr); > + fprintf_unfiltered (gdb_stderr, _("%s."), REPORT_BUGS_TO); > + } > + fputs_unfiltered ("\n\n", gdb_stderr); > + > if (problem->should_dump_core == internal_problem_ask) > { > if (!can_dump_core (reason)) > >