From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11331 invoked by alias); 5 May 2014 10:02:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11319 invoked by uid 89); 5 May 2014 10:02:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 05 May 2014 10:02:26 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s45A2JG1016130; Mon, 5 May 2014 12:02:19 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s45A2JOU026418; Mon, 5 May 2014 12:02:19 +0200 (CEST) Date: Mon, 05 May 2014 10:02:00 -0000 Message-Id: <201405051002.s45A2JOU026418@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: arnez@linux.vnet.ibm.com CC: gdb-patches@sourceware.org In-reply-to: <87vbtt3hkr.fsf@br87z6lw.de.ibm.com> (message from Andreas Arnez on Mon, 28 Apr 2014 11:54:12 +0200) Subject: Re: [RFC 12/23] regcache: Add functions suitable for regset_supply/collect. References: <87eh0h6bkq.fsf@br87z6lw.de.ibm.com> <87vbtt3hkr.fsf@br87z6lw.de.ibm.com> X-SW-Source: 2014-05/txt/msg00041.txt.bz2 > From: Andreas Arnez > Date: Mon, 28 Apr 2014 11:54:12 +0200 > > These functions are intended to suit all targets that don't require too > special logic in their regset supply/collect methods. Having such > generic functions helps reducing target-specific complexity. > > gdb/ > * regcache.c: Include "regset.h". > (regcache_supply_regset, regcache_collect_regset): New functions. > * regcache.h (struct regcache_map_entry): New structure. > (REGCACHE_MAP_SKIP_BYTES): New enum value. > (regcache_supply_regset, regcache_collect_regset): New prototypes. Sorry, but this doesn't strike me as a particular good interface. I'd say an approach that uses explicit offsets would be much better.