From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112099-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28602 invoked by alias); 28 Apr 2014 15:33:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 28591 invoked by uid 89); 28 Apr 2014 15:33:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: glazunov.sibelius.xs4all.nl
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 28 Apr 2014 15:33:24 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s3SFXH0l009464;	Mon, 28 Apr 2014 17:33:17 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s3SFXGW3003471;	Mon, 28 Apr 2014 17:33:17 +0200 (CEST)
Date: Mon, 28 Apr 2014 15:33:00 -0000
Message-Id: <201404281533.s3SFXGW3003471@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: arnez@linux.vnet.ibm.com
CC: gdb-patches@sourceware.org
In-reply-to: <87ppk14wh4.fsf@br87z6lw.de.ibm.com> (message from Andreas Arnez	on Mon, 28 Apr 2014 11:47:03 +0200)
Subject: Re: [RFC 05/23] X86: Replace regset_alloc() invocations by static regset structures.
References: <87eh0h6bkq.fsf@br87z6lw.de.ibm.com> <87ppk14wh4.fsf@br87z6lw.de.ibm.com>
X-SW-Source: 2014-04/txt/msg00589.txt.bz2

> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
> Date: Mon, 28 Apr 2014 11:47:03 +0200
> 
> diff --git a/gdb/amd64obsd-tdep.c b/gdb/amd64obsd-tdep.c
> index c5ed731..e7041c9 100644
> --- a/gdb/amd64obsd-tdep.c
> +++ b/gdb/amd64obsd-tdep.c
> @@ -49,11 +49,17 @@ amd64obsd_supply_regset (const struct regset *regset,
>  
>    gdb_assert (len >= tdep->sizeof_gregset + I387_SIZEOF_FXSAVE);
>  
> -  i386_supply_gregset (regset, regcache, regnum, regs, tdep->sizeof_gregset);
> +  i386_gregset.supply_regset (regset, regcache, regnum, regs,
> +			      tdep->sizeof_gregset);

I'm not too happy with the additional level of indirection you're
introducing here.  Don't particularly see the need to do this...