From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2967 invoked by alias); 21 Apr 2014 17:14:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2933 invoked by uid 89); 21 Apr 2014 17:14:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 21 Apr 2014 17:14:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E7BF1116100; Mon, 21 Apr 2014 13:14:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QmDS8iYK8sI8; Mon, 21 Apr 2014 13:14:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B50081160CA; Mon, 21 Apr 2014 13:14:53 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 27B34E09B7; Mon, 21 Apr 2014 10:14:53 -0700 (PDT) Date: Mon, 21 Apr 2014 17:14:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: GDB Patches Subject: Re: [PATCH] Remove unused variable Message-ID: <20140421171453.GA18355@adacore.com> References: <53553E27.6060009@ericsson.com> <20140421161232.GF4477@adacore.com> <53554D62.2010901@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53554D62.2010901@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-04/txt/msg00417.txt.bz2 > >> 2014-04-21 Simon Marchi > >> > >> * infrun.c (resume): Remove should_resume (unused). > > > > Unfortunately, your patch does much much much much much much much > > more than just removing "should_resume" :-). > > > > Can you please submit a patch that just removes that variable? > > I was afraid it would not be clear and I almost mentioned it in my > original message. There are a lot of +/- for a tiny change, because the > code looked like that: > > int should_resume = 1; > > /* Untouched stuff */ > > if (should_resume) > { > /* Lots of stuff that needs to be unindented. */ > ... > } > > The part that was unindented by four spaces generates a lot of +/-, but > I didn't change anything else than that, I swear ! Indeed. It went a little too fast - what threw me was the addition of resume_ptid's declaration at the start of the function. I did a quick "git diff -b" and it explains the patch. The patch is approved, but we should probably mention the fact that resume_ptid's declaration was moved up in the ChangeLog entry. Here is a link to request an account on sourceware.org, if you do not already have one (you can list me as your sponsor): https://sourceware.org/cgi-bin/pdw/ps_form.cgi Once that's out of the way, please commit an obvious patch to the gdb/MAINTAINERS file adding yourself to the "COMMIT AFTER APPROVAL" list (the patch should be treated like all other obvious patches, ie a copy should be sent to this mailing-list). Once that's all done, then you can push this commit as well. Please remember to send a quick confirmation that the commit was pushed to this mailing-list as well. Thank you, -- Joel