From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8512 invoked by alias); 2 Apr 2014 01:50:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8041 invoked by uid 89); 2 Apr 2014 01:50:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pa0-f54.google.com Received: from mail-pa0-f54.google.com (HELO mail-pa0-f54.google.com) (209.85.220.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 02 Apr 2014 01:50:07 +0000 Received: by mail-pa0-f54.google.com with SMTP id lf10so10753097pab.13 for ; Tue, 01 Apr 2014 18:50:05 -0700 (PDT) X-Received: by 10.66.232.40 with SMTP id tl8mr13432592pac.137.1396403405815; Tue, 01 Apr 2014 18:50:05 -0700 (PDT) Received: from bubble.grove.modra.org ([101.166.26.37]) by mx.google.com with ESMTPSA id op3sm651190pbc.40.2014.04.01.18.50.02 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Apr 2014 18:50:04 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 6923CEA00E4; Wed, 2 Apr 2014 12:19:59 +1030 (CST) Date: Wed, 02 Apr 2014 01:50:00 -0000 From: Alan Modra To: Pedro Alves Cc: "Metzger, Markus T" , Mark Wielaard , Cary Coutant , Doug Evans , gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: vdso handling Message-ID: <20140402014959.GZ18201@bubble.grove.modra.org> Mail-Followup-To: Pedro Alves , "Metzger, Markus T" , Mark Wielaard , Cary Coutant , Doug Evans , gdb-patches@sourceware.org, binutils@sourceware.org References: <20140313235347.GD3384@bubble.grove.modra.org> <20140318230939.GA9145@bubble.grove.modra.org> <5329879C.6070805@redhat.com> <20140320013305.GA13347@bubble.grove.modra.org> <532C5F60.80700@redhat.com> <20140328061321.GU18201@bubble.grove.modra.org> <53357B30.6040006@redhat.com> <20140328230037.GW18201@bubble.grove.modra.org> <533AC33E.8030700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <533AC33E.8030700@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-04/txt/msg00016.txt.bz2 On Tue, Apr 01, 2014 at 02:46:38PM +0100, Pedro Alves wrote: > On 03/28/2014 11:00 PM, Alan Modra wrote: > > > I believe the intent of rounding to a page was to pick up the file > > and program headers at the start of a file and section headers at the > > end, so let's do just that. On top of my last patch: > > Agreed. This works for me. Thanks! > > > - if (i_phdrs[i].p_align > 1) > > + /* Extend the beginning of the first pt_load to cover file > > + header and program headers. */ > > + if (first_phdr == &i_phdrs[i]) > > Minor nit: Perhaps the comment could say "first pt_load > if it covers offset 0"? Fixed. /* Extend the beginning of the first pt_load to cover file header and program headers, if we proved earlier that its aligned offset is 0. */ > Please don't use ATTRIBUTE_UNUSED under gdb/, it'd be flagged by the > ARI as a regression: Hmm, OK. Fixed and pushed. -- Alan Modra Australia Development Lab, IBM