Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: anton@samba.org (Anton Blanchard)
Cc: gdb-patches@sourceware.org, brobecker@adacore.com,
	       emachado@linux.vnet.ibm.com, luis_gustavo@mentor.com,
	       ulrich.weigand@de.ibm.com
Subject: Re: [PATCH 1/4] Fix ppc64 single step over atomic sequence testcase
Date: Fri, 28 Mar 2014 13:13:00 -0000	[thread overview]
Message-ID: <201403281313.s2SDDNuF029372@d03av02.boulder.ibm.com> (raw)
In-Reply-To: <1395978111-30706-1-git-send-email-anton@samba.org> from "Anton Blanchard" at Mar 28, 2014 02:41:48 PM

Anton Blanchard wrote:

> +++ b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s

> +#if _CALL_ELF == 2

I just noticed that a '.s' file is not run through
the preprocessor, and thus this fails (the # is
regarded as a comment ...).

You need to rename the file to .S (and update the
filename in the .exp file) for the test to work
successfully.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


      parent reply	other threads:[~2014-03-28 13:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28  3:41 Anton Blanchard
2014-03-28  3:42 ` [PATCH 2/4] Support up to 3 conditional branches in an atomic sequence Anton Blanchard
2014-03-28 13:12   ` Joel Brobecker
2014-03-28 17:13     ` Pedro Alves
2014-03-28 17:22       ` Pedro Alves
2014-03-28 17:32       ` Joel Brobecker
2014-03-28 17:58         ` Pedro Alves
2014-03-28 18:10           ` Joel Brobecker
2014-03-28  3:42 ` [PATCH 3/4] Add multiple branches to ppc64 single step through atomic sequence testcase Anton Blanchard
2014-03-28 13:14   ` Joel Brobecker
2014-03-28  3:42 ` [PATCH 4/4] Add lbarx/stbcx., lharx/sthcx. and lqarx/stqcx. single stepping Anton Blanchard
2014-03-28 13:17   ` Joel Brobecker
2014-03-28 13:05 ` [PATCH 1/4] Fix ppc64 single step over atomic sequence testcase Joel Brobecker
2014-03-31  2:55   ` Anton Blanchard
2014-03-28 13:13 ` Ulrich Weigand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201403281313.s2SDDNuF029372@d03av02.boulder.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=anton@samba.org \
    --cc=brobecker@adacore.com \
    --cc=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis_gustavo@mentor.com \
    --cc=ulrich.weigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox