From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30495 invoked by alias); 26 Mar 2014 13:40:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30477 invoked by uid 89); 26 Mar 2014 13:40:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 26 Mar 2014 13:40:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 46A90116803; Wed, 26 Mar 2014 09:40:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8vvzCCw-wnsl; Wed, 26 Mar 2014 09:40:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1E1E91166AC; Wed, 26 Mar 2014 09:40:47 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 92809E07DC; Wed, 26 Mar 2014 06:40:48 -0700 (PDT) Date: Wed, 26 Mar 2014 13:40:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: "gp >> \"gdb-patches@sourceware.org ml\"" Subject: Re: [RFA] Fix c++/16253 (tag/variable name collision) Message-ID: <20140326134048.GA24501@adacore.com> References: <532C810F.7010809@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <532C810F.7010809@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-03/txt/msg00614.txt.bz2 Hey again, Keith, > ChangeLog > 2014-03-20 Keith Seitz > > PR c++/16253 > * ada-lang.c (ada_symbol_matches_domain): Moved here and renamed > from symbol_matches_domain in symtab.c. All local callers > of symbol_matches_domain updated. > (standard_lookup): If DOMAIN is VAR_DOMAIN and no symbol is found, > search STRUCT_DOMAIN. > (ada_find_any_type_symbol): Do not search STRUCT_DOMAIN > independently. standard_lookup will do that automatically. > * ada-tasks.c (get_tcb_types_info): Search STRUCT_DOMAIN for > types, not VAR_DOMAIN. > * cp-namespace.c (cp_lookup_symbol_nonlocal): Explain when/why > VAR_DOMAIN searches may return a STRUCT_DOMAIN match. > (cp_lookup_symbol_in_namespace): Likewise. > If no VAR_DOMAIN symbol is found, search STRUCT_DOMAIN. > (cp_lookup_symbol_exports): Explain when/why VAR_DOMAIN searches > may return a STRUCT_DOMAIN match. > (lookup_symbol_file): Search for the class name in STRUCT_DOMAIN. > * cp-support.c: Include language.h. > (inspect_type): Explicitly search STRUCT_DOMAIN before searching > VAR_DOMAIN. > * psymtab.c (match_partial_symbol): Compare the requested > domain with the symbol's domain directly. > (lookup_partial_symbol): Likewise. > * symtab.c (lookup_symbol_in_language): Explain when/why > VAR_DOMAIN searches may return a STRUCT_DOMAIN match. > If no VAR_DOMAIN symbol is found, search STRUCT_DOMAIN for > appropriate languages. > (symbol_matches_domain): Renamed `ada_symbol_matches_domain' > and moved to ada-lang.c > (lookup_block_symbol): Explain that this function only returns > symbol matching the requested DOMAIN. > Compare the requested domain with the symbol's domain directly. > (iterate_over_symbols): Compare the requested domain with the > symbol's domain directly. > * symtab.h (symbol_matches_domain): Remove. Would you mind committing the ada-tasks.c change now, and separately from the rest? It's an improvement on its own. FTR, I tested this part of the patch isolated from the rest on x86_64-linux. Thanks! -- Joel