From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25063 invoked by alias); 19 Mar 2014 22:33:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25052 invoked by uid 89); 19 Mar 2014 22:33:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Mar 2014 22:33:16 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2JMXCv5017245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Mar 2014 18:33:12 -0400 Received: from host2.jankratochvil.net (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2JMX738020476 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 19 Mar 2014 18:33:10 -0400 Date: Wed, 19 Mar 2014 22:33:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v4 8/8] Tests for validate symbol file using build-id Message-ID: <20140319223307.GB5398@host2.jankratochvil.net> References: <20140302195248.10290.22958.stgit@host1.jankratochvil.net> <20140302195349.10290.47187.stgit@host1.jankratochvil.net> <531D332F.10309@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <531D332F.10309@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00474.txt.bz2 On Mon, 10 Mar 2014 04:36:15 +0100, Yao Qi wrote: > On 03/03/2014 03:53 AM, Jan Kratochvil wrote: > > gdb/testsuite/ > > 2014-02-26 Aleksandar Ristovski > > > Tests for validate symbol file using build-id. > > * gdb.base/solib-mismatch-lib.c: New file. > > * gdb.base/solib-mismatch-libmod.c: New file. > > * gdb.base/solib-mismatch.c: New file. > > * gdb.base/solib-mismatch.exp: New file. > > Since the test is about GDBserver, so IWBN to move them > testsuite/gdb.server/ directory. Done. > > +if ![is_remote target] { > > + untested "only gdbserver supports build-id reporting" > > + return -1 > > +} > > +if { [board_info target sockethost] != "localhost:" } { > > + # The testcase below could be fixed for remote targets. > > + untested "only gdbserver on localhost is supported (found [board_info target sockethost])" > > + return -1 > > +} > > I don't figure out why this test should be only performed against > native gdbserver. If you ask why I have removed the linux-nat support as it regressed linux-nat functionality reading wrong build-id for local files, described in: https://sourceware.org/ml/gdb-patches/2014-02/msg00842.html If you ask why it does not work for gdbserver running on a different computer - that could be working but I have never run such a setup, I do not think I would get all the uploads/downloads right without testing and I just did not want to put more time into setting it up and fixing all. But in the meantime upon other discussions this '!= "localhost:"' condition has been removed, the testcase is apparently broken with different-filesystem gdbserver but someone occasionally fixing up such testcases should find it more easier than if the testcase disable was present there. > > +file delete -force -- "${binlibfiledirrun}" > > +file mkdir "${binlibfiledirrun}" > > + > > If test is only run in native-gdbserver, these file operations are fine, > otherwise, we may use "rmeote_file target delete" and > "remote_exec target mkdir" here. Discussed above. > > + gdb_test_no_output "set solib-search-path \"${binlibfiledirgdb}\"" "" > > + if { [gdb_test "cd ${binlibfiledirgdb}" "" ""] != 0 } { > > + untested "cd ${binlibfiledirgdb}" > > Caller of proc solib_matching_test emits UNTESTED, so don't have to do > it again inside sobli_matching_test. I have rather reworked it a bit now with with_test_prefix() instead of the extra 'msg' parameter. Thanks, Jan