From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22481 invoked by alias); 19 Mar 2014 12:34:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22471 invoked by uid 89); 19 Mar 2014 12:34:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 19 Mar 2014 12:34:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A60851164F3; Wed, 19 Mar 2014 08:34:24 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id reyxuE9nuOAx; Wed, 19 Mar 2014 08:34:24 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7547E1164B7; Wed, 19 Mar 2014 08:34:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8BBD9E0AB3; Wed, 19 Mar 2014 05:34:23 -0700 (PDT) Date: Wed, 19 Mar 2014 12:34:00 -0000 From: Joel Brobecker To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][PR/backtrace 16721] Fix erroneous backtrace on AVR Message-ID: <20140319123423.GF4282@adacore.com> References: <53288819.7080903@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53288819.7080903@embecosm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-03/txt/msg00445.txt.bz2 > 2014-03-18 Pierre Langlois > > * avr-tdep.c (avr_scan_prologue): Accept push r1 instruction for small > stack allocation. Now that Tristan approved the patch, do you have an FSF copyright assignment on file? This patch is small that we can push it in without; but if you are planning on sending more, you'll need one. Just let me know and I will get you a message to get you started (it takes a while to complete, so the sooner the better). One remark on the ChangeLog; the formatting is off a bit. It should be indented by one tab, and the indentation should be the same, regardless of whether the line starts with a '*' or not - no extra indentation for continuation lines. Thus: * avr-tdep.c (avr_scan_prologue): Accept push r1 instruction for small stack allocation. (in emails, it's not important to be using 8 spaces or 1 tab, but in the CL, we tend to be picky about it). Thanks! -- Joel