From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1746 invoked by alias); 12 Mar 2014 08:08:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1730 invoked by uid 89); 12 Mar 2014 08:08:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 12 Mar 2014 08:08:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id ACD1511663C; Wed, 12 Mar 2014 04:07:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id D0xPhk9bx2tr; Wed, 12 Mar 2014 04:07:59 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7FE941164AF; Wed, 12 Mar 2014 04:07:59 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 88053E03A3; Wed, 12 Mar 2014 01:07:59 -0700 (PDT) Date: Wed, 12 Mar 2014 08:08:00 -0000 From: Joel Brobecker To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][PR breakpoints/16606] AVR8 breakpoint out of range, decrement pc after break Message-ID: <20140312080759.GD4882@adacore.com> References: <531A2316.5090507@embecosm.com> <20140310110809.GC4882@adacore.com> <531EFA75.10008@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <531EFA75.10008@embecosm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-03/txt/msg00277.txt.bz2 > I just realized that support for multiple address spaces was added > but never documented. > So the way to solve the issue is to add the @code qualifier as such: > > (gdb) break * (@code void *) 0x10e > > And it will set the TYPE_CODE_SPACE instance flag to the type when > calling integer_to_address. > > However, shouldn't @code be the default for breakpoints? I am not really sure about that. I know my example is not going to be the most frequent situation ever, but what if the code is data memory? I admit I didn't know about the @code, is there an equivalent for data pointers as well? If that were a yes, I think we could argue that indeed, @code would be a better default, and look into what it would take to make that happen. -- Joel