From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18399 invoked by alias); 7 Mar 2014 13:50:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18386 invoked by uid 89); 7 Mar 2014 13:50:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 07 Mar 2014 13:50:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1C0B41166BD; Fri, 7 Mar 2014 08:50:53 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6jMlZfHR7ibU; Fri, 7 Mar 2014 08:50:53 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E52E711668A; Fri, 7 Mar 2014 08:50:52 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 01F6AE0BD5; Fri, 7 Mar 2014 05:50:51 -0800 (PST) Date: Fri, 07 Mar 2014 13:50:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Error on bad count number Message-ID: <20140307135051.GJ16858@adacore.com> References: <1394023608-10761-1-git-send-email-yao@codesourcery.com> <1394023608-10761-3-git-send-email-yao@codesourcery.com> <20140305142939.GB16858@adacore.com> <531749BA.8050806@redhat.com> <5318456D.3010709@codesourcery.com> <53186842.9030704@redhat.com> <5319938B.60402@codesourcery.com> <5319C931.9090907@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5319C931.9090907@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-03/txt/msg00185.txt.bz2 > Nothing in a name like "get number" suggests to me only positive > numbers would be returned. I think it should be up to the > caller to handle whether the returned value is valid in > that context. I agree. If useful, we could have a second routine that calls get_number and errors out if the number returned was negative, like get_natural_number for instance. -- Joel