From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25879 invoked by alias); 5 Mar 2014 14:38:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25866 invoked by uid 89); 5 Mar 2014 14:38:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 05 Mar 2014 14:38:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F1E7911661A; Wed, 5 Mar 2014 09:38:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8MLdaaESikbV; Wed, 5 Mar 2014 09:38:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C86DF1165BD; Wed, 5 Mar 2014 09:38:11 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id AD0ABE08BE; Wed, 5 Mar 2014 06:38:13 -0800 (PST) Date: Wed, 05 Mar 2014 14:38:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Handle parse number error in goto_bookmark_command Message-ID: <20140305143813.GC16858@adacore.com> References: <1394023608-10761-1-git-send-email-yao@codesourcery.com> <1394023608-10761-4-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394023608-10761-4-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-03/txt/msg00120.txt.bz2 > (gdb) goto-bookmark 1.1 > goto-bookmark: no bookmark found for '1.1'. I would use "invalid bookmark number"... > 2014-03-05 Yao Qi > > * reverse.c (goto_bookmark_command): Add local 'p'. Emit error > early if get_number returns zero. Use 'p' instead of 'args'. Otherwise, LGTM. > --- > gdb/reverse.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/gdb/reverse.c b/gdb/reverse.c > index 582252c..0ceecf9 100644 > --- a/gdb/reverse.c > +++ b/gdb/reverse.c > @@ -250,6 +250,7 @@ goto_bookmark_command (char *args, int from_tty) > { > struct bookmark *b; > unsigned long num; > + char *p = args; > > if (args == NULL || args[0] == '\0') > error (_("Command requires an argument.")); > @@ -274,6 +275,10 @@ goto_bookmark_command (char *args, int from_tty) > > /* General case. Bookmark identified by bookmark number. */ > num = get_number (&args); > + > + if (num == 0) > + error (_("goto-bookmark: no bookmark found for '%s'."), p); > + > ALL_BOOKMARKS (b) > if (b->number == num) > break; > @@ -285,7 +290,7 @@ goto_bookmark_command (char *args, int from_tty) > return; > } > /* Not found. */ > - error (_("goto-bookmark: no bookmark found for '%s'."), args); > + error (_("goto-bookmark: no bookmark found for '%s'."), p); > } > > static int > -- > 1.7.7.6 -- Joel