From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12268 invoked by alias); 5 Mar 2014 14:22:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12248 invoked by uid 89); 5 Mar 2014 14:22:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 05 Mar 2014 14:22:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EB26E116631; Wed, 5 Mar 2014 09:22:33 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ladYkvWb2aAL; Wed, 5 Mar 2014 09:22:33 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C3A8911662F; Wed, 5 Mar 2014 09:22:33 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 17ED6E08BE; Wed, 5 Mar 2014 06:22:36 -0800 (PST) Date: Wed, 05 Mar 2014 14:22:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [OBV PATCH 1/4] Add a newline in output messages Message-ID: <20140305142236.GA16858@adacore.com> References: <1394023608-10761-1-git-send-email-yao@codesourcery.com> <1394023608-10761-2-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394023608-10761-2-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-03/txt/msg00118.txt.bz2 > 2014-03-05 Yao Qi > > * cli/cli-utils.c (get_number_trailer): Add '\n' at the end of > message. Obvious indeed. The error handling is a little different from the usual, where error would typically be used; especially since zero can be a valid number. And this leads to this sort of odd behavior: (gdb) set $v := 1.1 (gdb) b a Breakpoint 1 at 0x401558: file a.adb, line 3. (gdb) cond $v 1 = 1 Convenience variable must have integer value. Bad breakpoint argument: '$v 1 = 1' Probably for a rainy day... > --- > gdb/cli/cli-utils.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gdb/cli/cli-utils.c b/gdb/cli/cli-utils.c > index e18e357..a0ebc11 100644 > --- a/gdb/cli/cli-utils.c > +++ b/gdb/cli/cli-utils.c > @@ -50,7 +50,7 @@ get_number_trailer (char **pp, int trailer) > retval = value_as_long (val); > else > { > - printf_filtered (_("History value must have integer type.")); > + printf_filtered (_("History value must have integer type.\n")); > retval = 0; > } > } > -- > 1.7.7.6 -- Joel