From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4815 invoked by alias); 28 Feb 2014 17:52:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4806 invoked by uid 89); 28 Feb 2014 17:52:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 28 Feb 2014 17:52:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A8FF5116524; Fri, 28 Feb 2014 12:51:59 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QkNeXLAPWTIx; Fri, 28 Feb 2014 12:51:59 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 80C5E116517; Fri, 28 Feb 2014 12:51:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A2EBDE03BD; Fri, 28 Feb 2014 09:51:58 -0800 (PST) Date: Fri, 28 Feb 2014 17:52:00 -0000 From: Joel Brobecker To: Sanimir Agovic Cc: tromey@redhat.com, keven.boell@intel.com, gdb-patches@sourceware.org Subject: Re: [PATCH v5 11/15] test: cover subranges with present DW_AT_count attribute Message-ID: <20140228175158.GD16479@adacore.com> References: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> <1391704056-25246-12-git-send-email-sanimir.agovic@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391704056-25246-12-git-send-email-sanimir.agovic@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00871.txt.bz2 On Thu, Feb 06, 2014 at 05:27:32PM +0100, Sanimir Agovic wrote: > The dwarf attribute DW_AT_count specifies the elements of a subrange. > This test covers subranges with present count but absent upper bound > attribute, both with static and dynamic attribute values. > > 2013-11-26 Sanimir Agovic > Keven Boell > > testsuite: > * gdb.dwarf2/count.exp: New test. One small comment. Pre-approved with those changes made. > +gdb_test "ptype array" "type = char \\\[5\\\]" "ptype array" > +gdb_test "whatis array" "type = char \\\[5\\\]" "whatis array" > +gdb_test "print array" "\"hello\"" "print array" > +gdb_test "print sizeof array" "5" "print sizeof array" > + > +gdb_test "ptype static_array" "type = char \\\[5\\\]" "ptype static_array" > +gdb_test "whatis static_array" "type = char \\\[5\\\]" "whatis static_array" > +gdb_test "print static_array" "\"world\"" "print static_array" > +gdb_test "print sizeof static_array" "5" "print sizeof static_array" In the 4 "print" tests, can you start the expected output by " = "? In particular for the sizeof tests, it'll make sure that you don't match a bogus return value that happens to contain a 5 in it. -- Joel