From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13382 invoked by alias); 28 Feb 2014 16:53:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13370 invoked by uid 89); 28 Feb 2014 16:53:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 28 Feb 2014 16:53:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 03EA4116743; Fri, 28 Feb 2014 11:53:02 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AWnmivhGThs3; Fri, 28 Feb 2014 11:53:01 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B951F11673F; Fri, 28 Feb 2014 11:53:01 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5B156E03BD; Fri, 28 Feb 2014 08:53:00 -0800 (PST) Date: Fri, 28 Feb 2014 16:53:00 -0000 From: Joel Brobecker To: Sanimir Agovic Cc: tromey@redhat.com, keven.boell@intel.com, gdb-patches@sourceware.org Subject: Re: [PATCH v5 08/15] vla: support for DW_AT_count Message-ID: <20140228165300.GA16479@adacore.com> References: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> <1391704056-25246-9-git-send-email-sanimir.agovic@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391704056-25246-9-git-send-email-sanimir.agovic@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00867.txt.bz2 > 2013-11-19 Sanimir Agovic > Keven Boell > > * dwarf2read.c (read_subrange_type): Convert DW_AT_count to a dynamic > property and store it as the high bound and flag the range accordingly. > * gdbtypes.c (resolve_dynamic_bounds): If range is flagged as > RANGE_UPPER_BOUND_IS_COUNT assign low + high - 1 as the new high bound. > * gdbtypes.h (enum range_flags): New enum. > (struct range_bounds): Add flags member. Overall, the patch looks OK to me, but I'd rather we be consistent with what we've been doing with other type flags, and use a bitfield instead. I think that'll simplify your patch a bit. -- Joel