From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16160 invoked by alias); 27 Feb 2014 22:03:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16149 invoked by uid 89); 27 Feb 2014 22:03:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 27 Feb 2014 22:03:20 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8AD0D116586; Thu, 27 Feb 2014 17:03:18 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0HCpM+dMCuKA; Thu, 27 Feb 2014 17:03:18 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4AF4B11655D; Thu, 27 Feb 2014 17:03:18 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C8D34E1049; Thu, 27 Feb 2014 14:03:16 -0800 (PST) Date: Thu, 27 Feb 2014 22:03:00 -0000 From: Joel Brobecker To: Sanimir Agovic Cc: tromey@redhat.com, keven.boell@intel.com, gdb-patches@sourceware.org Subject: Re: [PATCH v5 01/15] refactoring: rename create_range_type to create_static_range_type Message-ID: <20140227220316.GA10536@adacore.com> References: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> <1391704056-25246-2-git-send-email-sanimir.agovic@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391704056-25246-2-git-send-email-sanimir.agovic@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00849.txt.bz2 On Thu, Feb 06, 2014 at 05:27:22PM +0100, Sanimir Agovic wrote: > 2013-12-19 Sanimir Agovic > Keven Boell > > * gdbtypes.c (create_static_range_type): Renamed from create_range_type. > * gdbtypes.h (create_static_range_type): Renamed from create_range_type. > * ada-lang.c (*): All uses of create_range_type updated. > * coffread.c (*): All uses of create_range_type updated. > * dwarf2read.c (*): All uses of create_range_type updated. > * f-exp.y (*): All uses of create_range_type updated. > * m2-valprint.c (*): All uses of create_range_type updated. > * mdebugread.c (*): All uses of create_range_type updated. > * stabsread.c (*): All uses of create_range_type updated. > * valops.c (*): All uses of create_range_type updated. > * valprint.c (*): All uses of create_range_type updated. Can you remove the " (*)" from the ChangeLog entries? These are not needed. Thus, for instance: * ada-lang.c: All uses of create_range_type updated. I have a few minor formatting nits highighted below, but this patch is pre-approved with those changes. Thank you! > diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > index 786ca7a..0d93267 100644 > --- a/gdb/ada-lang.c > +++ b/gdb/ada-lang.c > @@ -1875,8 +1875,8 @@ ada_type_of_array (struct value *arr, int bounds) > struct value *high = desc_one_bound (descriptor, arity, 1); > > arity -= 1; > - create_range_type (range_type, value_type (low), > - longest_to_int (value_as_long (low)), > + create_static_range_type (range_type, value_type (low), > + longest_to_int (value_as_long (low)), > longest_to_int (value_as_long (high))); The indentation of the 3 line (longest_to_int) needs to be adjusted. > struct type *index_type = > - create_range_type (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE (type0)), > - low, high); > + create_static_range_type (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE (type0)), > + low, high); I know that you've been following the style in this file, but the assignment operator should be at the start of the next line. We don't need or even want to fix all incorrect forms in this patch, but can we fix the ones we touch? > struct type *index_type = > - create_range_type (NULL, TYPE_INDEX_TYPE (type), low, high); > + create_static_range_type (NULL, TYPE_INDEX_TYPE (type), low, high); Same here, please. > struct type *index_type = > - create_range_type (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE (arr_type0)), > - low, low - 1); > + create_static_range_type > + (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE (arr_type0)), low, low - 1); Same as above. Also, can you indent the '(' for the start of the function parameters 2 characters past the funtion's indentation? Something like the following: struct type *index_type = create_static_range_type (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE (arr_type0)), low, low - 1); -- Joel