Re: [commit] [patch] Fix solib list reading asan error (for PR 8882)

Mark Kettenis
2014-02-27T20:56:56Z

> Date: Thu, 27 Feb 2014 21:17:31 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> On Wed, 26 Feb 2014 23:09:18 +0100, Jan Kratochvil wrote:
> > gdb/
> > 2014-02-26 Jan Kratochvil <jan.kratochvil@redhat.com>
> >
> > Additional PR 8882 fix.
> > * solib-svr4.c (svr4_read_so_list): Change first to first_l_name.
>
> Checked in already as it is complicating the testing under asan:
> c91550fc5d8dae5f1140bca649690fa13e5276e9

Broke my build because ithe compiler warned that first_l_name may be
used uninitialized. And I agree, so I committed the diff below as
obvious.

From c725e7b6878220bbeac44b86a2581d74f16b497c Mon Sep 17 00:00:00 2001
From: Mark Kettenis <kettenis@gnu.org>
Date: Thu, 27 Feb 2014 21:51:08 +0100
Subject: [PATCH] Prevent compiler warning.

GCC 4.2.1 complains about first_l_name may be used uninitialized, and my brain
agrees.

gdb/ChangeLog:

* solib-svr4.c (svr4_read_so_list): Initialize first_l_name to 0.
---
gdb/ChangeLog | 4 ++++
gdb/solib-svr4.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6a8fc0c..c99510c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2014-02-27 Mark Kettenis <kettenis@gnu.org>

+ * solib-svr4.c (svr4_read_so_list): Initialize first_l_name to 0.
+
+2014-02-27 Mark Kettenis <kettenis@gnu.org>
+
* sparc-nat.c (sparc_xfer_wcookie): Always use process ID.

2014-02-27 Jan Kratochvil <jan.kratochvil@redhat.com>
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 6c4dff7..4c94f9f 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -1306,7 +1306,7 @@ static int
svr4_read_so_list (CORE_ADDR lm, CORE_ADDR prev_lm,
struct so_list ***link_ptr_ptr, int ignore_first)
{
- CORE_ADDR first_l_name;
+ CORE_ADDR first_l_name = 0;
CORE_ADDR next_lm;

for (; lm != 0; prev_lm = lm, lm = next_lm)
--
1.8.5.3