From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23674 invoked by alias); 20 Feb 2014 17:48:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23660 invoked by uid 89); 20 Feb 2014 17:48:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 20 Feb 2014 17:48:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C3A15116646; Thu, 20 Feb 2014 12:48:22 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 21rAxCFpHRVo; Thu, 20 Feb 2014 12:48:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 947AC116643; Thu, 20 Feb 2014 12:48:22 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A2A64E08CA; Thu, 20 Feb 2014 18:48:21 +0100 (CET) Date: Thu, 20 Feb 2014 17:48:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: PING: [PATCH v4] fixed inherit_abstract_dies infinite recursive call Message-ID: <20140220174821.GF4113@adacore.com> References: <20140210142831.GY5485@adacore.com> <20140211021937.GD5485@adacore.com> <20140213073112.GS5485@adacore.com> <52FC7BC8.2010400@gmail.com> <20140214033411.GD5485@adacore.com> <20140219075900.GC4270@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="rJwd6BRFiFCcLxzm" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00652.txt.bz2 --rJwd6BRFiFCcLxzm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1042 > >> 2014-02-18 lin zuojian > >> Joel Brobecker > >> Doug Evans > >> > >> PR symtab/16581 > >> * dwarf2read.c (struct die_info): New member in_process. > >> (reset_die_in_process): New function. > >> (process_die): Set it at the start, reset when returning. > >> (inherit_abstract_dies): Only call process_die if origin_child_die > >> not already being processed. > >> > >> testsuite/ > >> * gdb.dwarf2/dw2-icycle.S: New file. > >> * gdb.dwarf2/dw2-icycle.c: New file. > >> * gdb.dwarf2/dw2-icycle.exp: New file. [...] > Committed. > [with a small tweak to the testcase (added a comment)] I noticed something as well (in my testcase), which I think will make it fail with an ARM bare-metal compiler. Fix attached and pushed. gdb/testsuite/ChangeLog: * gdb.dwarf2/dw2-icycle.S: Remove second and third parameters in .section pseudo-op. Tested on x86_64-linux... -- Joel --rJwd6BRFiFCcLxzm Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Simplify-.section-in-dw2-icycle.S.patch" Content-length: 1725 >From 83deb43f87f098f7858db8643786301eb73875f7 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Thu, 20 Feb 2014 18:34:45 +0100 Subject: [PATCH] Simplify .section in dw2-icycle.S The arm-elf assembler chokes on the extra parameters in the .section pseudo-op, so this patch removes them. gdb/testsuite/ChangeLog: * gdb.dwarf2/dw2-icycle.S: Remove second and third parameters in .section pseudo-op. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.dwarf2/dw2-icycle.S | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 52dff12..d1d99f8 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-02-20 Joel Brobecker + + * gdb.dwarf2/dw2-icycle.S: Remove second and third parameters + in .section pseudo-op. + 2014-02-20 lin zuojian Joel Brobecker Doug Evans diff --git a/gdb/testsuite/gdb.dwarf2/dw2-icycle.S b/gdb/testsuite/gdb.dwarf2/dw2-icycle.S index 6bc533a..1f84e4a 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-icycle.S +++ b/gdb/testsuite/gdb.dwarf2/dw2-icycle.S @@ -33,7 +33,7 @@ p__top: .LFE2: .Letext0: - .section .debug_info,"",@progbits + .section .debug_info .Ldebug_info0: .4byte .Ledebug_info0 - .Lsdebug_info0 /* Length of CU Info */ .Lsdebug_info0: @@ -118,7 +118,7 @@ p__top: .byte 0 /* end of children of DIE 0xb */ .Ledebug_info0: - .section .debug_abbrev,"",@progbits + .section .debug_abbrev .Ldebug_abbrev0: .uleb128 0x1 /* (abbrev code) */ .uleb128 0x11 /* (TAG: DW_TAG_compile_unit) */ -- 1.8.3.2 --rJwd6BRFiFCcLxzm--