From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18963 invoked by alias); 20 Feb 2014 15:56:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18953 invoked by uid 89); 20 Feb 2014 15:56:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 20 Feb 2014 15:56:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5A9A811673B; Thu, 20 Feb 2014 10:56:12 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BCreCGeOWsqJ; Thu, 20 Feb 2014 10:56:12 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2A49F11673A; Thu, 20 Feb 2014 10:56:12 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 2A9C2E08C9; Thu, 20 Feb 2014 16:56:11 +0100 (CET) Date: Thu, 20 Feb 2014 15:56:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] procfs.c: Don't install a deprecated_xfer_memory method Message-ID: <20140220155611.GA17210@adacore.com> References: <1392841775-19126-1-git-send-email-palves@redhat.com> <1392841775-19126-4-git-send-email-palves@redhat.com> <20140220154826.GD4113@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <20140220154826.GD4113@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00642.txt.bz2 --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 825 > > gdb/ > > 2014-02-19 Pedro Alves > > > > * procfs.c (procfs_target): Don't install procfs_xfer_memory as > > deprecated_xfer_memory hook. > > (procfs_xfer_partial): Call procfs_xfer_memory instead > > of the deprecated_xfer_memory target hook. > > (procfs_xfer_memory): Adjust interface as a to_xfer_partial > > helper. > > FYI: I tried to test it, but the sparc-solaris debugger appears to be > badly broken at the moment, and I won't have much time left this week > to investigate the failures, so I'll schedule that for next week. I forgot to attach a small patch that fixes a build failure because of a declaration that no longer matches the definition... After your patch, we could probably avoid the need for this declaration by swapping two functions, but for another day. -- Joel --azLHFNyN32YCQGCU Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Small-fixup.patch" Content-length: 803 >From c4116d749ac04b4c77a25f03c748b6a170cae4e5 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Thu, 20 Feb 2014 15:41:34 +0100 Subject: [PATCH] Small fixup. --- gdb/procfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/procfs.c b/gdb/procfs.c index 0e2112b..8887f10 100644 --- a/gdb/procfs.c +++ b/gdb/procfs.c @@ -129,7 +129,8 @@ static ptid_t procfs_wait (struct target_ops *, ptid_t, struct target_waitstatus *, int); static enum target_xfer_status procfs_xfer_memory (gdb_byte *, const gdb_byte *, - ULONGEST, ULONGEST); + ULONGEST, ULONGEST, + ULONGEST *); static target_xfer_partial_ftype procfs_xfer_partial; static int procfs_thread_alive (struct target_ops *ops, ptid_t); -- 1.7.10.4 --azLHFNyN32YCQGCU--