From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13905 invoked by alias); 20 Feb 2014 15:48:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13872 invoked by uid 89); 20 Feb 2014 15:48:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 20 Feb 2014 15:48:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E8EB71164F3; Thu, 20 Feb 2014 10:48:33 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PaKHmixq040i; Thu, 20 Feb 2014 10:48:33 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2D6FF116503; Thu, 20 Feb 2014 10:48:33 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E3B37E08C9; Thu, 20 Feb 2014 16:48:26 +0100 (CET) Date: Thu, 20 Feb 2014 15:48:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] procfs.c: Don't install a deprecated_xfer_memory method Message-ID: <20140220154826.GD4113@adacore.com> References: <1392841775-19126-1-git-send-email-palves@redhat.com> <1392841775-19126-4-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1392841775-19126-4-git-send-email-palves@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00641.txt.bz2 Hi Pedro, > This removes yet another instance of a deprecated_xfer_memory user. > > I don't have any way to test this. > > gdb/ > 2014-02-19 Pedro Alves > > * procfs.c (procfs_target): Don't install procfs_xfer_memory as > deprecated_xfer_memory hook. > (procfs_xfer_partial): Call procfs_xfer_memory instead > of the deprecated_xfer_memory target hook. > (procfs_xfer_memory): Adjust interface as a to_xfer_partial > helper. FYI: I tried to test it, but the sparc-solaris debugger appears to be badly broken at the moment, and I won't have much time left this week to investigate the failures, so I'll schedule that for next week. -- Joel