From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21780 invoked by alias); 19 Feb 2014 07:59:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21766 invoked by uid 89); 19 Feb 2014 07:59:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 19 Feb 2014 07:59:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 717441164E9; Wed, 19 Feb 2014 02:59:07 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id y1c+W4RbdLzd; Wed, 19 Feb 2014 02:59:07 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1AC79116453; Wed, 19 Feb 2014 02:59:06 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 09DD4E0EFE; Wed, 19 Feb 2014 08:59:01 +0100 (CET) Date: Wed, 19 Feb 2014 07:59:00 -0000 From: Joel Brobecker To: Doug Evans Cc: lin zuojian , "gdb-patches@sourceware.org" , Tom Tromey , linzj Subject: Re: PING: [PATCH v4] fixed inherit_abstract_dies infinite recursive call Message-ID: <20140219075900.GC4270@adacore.com> References: <1390374431-17981-1-git-send-email-manjian2006@gmail.com> <20140128120600.GG4101@adacore.com> <20140210142831.GY5485@adacore.com> <20140211021937.GD5485@adacore.com> <20140213073112.GS5485@adacore.com> <52FC7BC8.2010400@gmail.com> <20140214033411.GD5485@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00594.txt.bz2 > Hi. > Sorry for the delay! No, Thank You for looking into it! :) > I spent some time looking for a cleverer patch, but in the end I think the > simplicity of this patch is nice. :) > > 2014-02-18 lin zuojian > Joel Brobecker > Doug Evans > > PR symtab/16581 > * dwarf2read.c (struct die_info): New member in_process. > (reset_die_in_process): New function. > (process_die): Set it at the start, reset when returning. > (inherit_abstract_dies): Only call process_die if origin_child_die > not already being processed. > > testsuite/ > * gdb.dwarf2/dw2-icycle.S: New file. > * gdb.dwarf2/dw2-icycle.c: New file. > * gdb.dwarf2/dw2-icycle.exp: New file. That looks good to me, with one tiny little CS comment (see below). > +static void > +reset_die_in_process (void *arg) > +{ > + struct die_info *die = arg; > + die->in_process = 0; Missing empty line after local variable declaration. Thanks again, -- Joel